9063 init chainInfo #9477

turadg · 2024-06-10T01:25:11Z

refs: #9063

Description

Progress on,

orchestration - chain - provide well-known chain #9063

To be closed when all the names in the checklist are present.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

Updated test setup

Upgrade Considerations

Not yet deployed

cloudflare-workers-and-pages · 2024-06-10T01:29:13Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`5d4b6fd`
Status:	✅ Deploy successful!
Preview URL:	https://2ea7b05b.agoric-sdk.pages.dev
Branch Preview URL:	https://9063-init-chaininfo.agoric-sdk.pages.dev

View logs

dckc · 2024-06-10T15:17:05Z

a3p-integration/proposals/b:enable-orchestration/package.json

+  "ava": {
+    "concurrency": 1,
+    "serial": true,


@0xpatrickdev you mentioned using serial in the starship work; apparently that's pretty normal for this sort of thing.

dckc

I'm not sure about some details around publishNameHubs

dckc · 2024-06-10T15:18:13Z

packages/boot/test/bootstrapTests/demo-config.test.ts

@@ -16,7 +16,6 @@ const makeDefaultTestContext = async t => {
  );
  return swingsetTestKit;
 };
-


stray/left-over edit?

spacing for readability

dckc · 2024-06-10T15:23:06Z

packages/boot/test/bootstrapTests/lca.test.ts

-  const current = await wd.getCurrentWalletRecord();
-  const latest = await wd.getLatestUpdateRecord();
+  const current = wd.getCurrentWalletRecord();
+  const latest = wd.getLatestUpdateRecord();


synchronous IO feels funny. But I guess the wallet driver API is that it doesn't do IO here?

right, what it's reading is local

dckc · 2024-06-10T15:24:30Z

packages/boot/test/bootstrapTests/vtransfer.test.ts

@@ -17,7 +17,6 @@ const makeDefaultTestContext = async t => {
  );
  return swingsetTestKit;
 };
-


another stray / leftover edit?

dckc · 2024-06-10T15:27:12Z

packages/orchestration/src/proposals/orchestration-proposal.js

+ *       stakeBld: Installation<
+ *         import('../../src/examples/stakeBld.contract.js').start


that would be a Promise<Installation<...>>, right?

In fact, why declare a stakeBld installation here at all? it's not used.

thanks. leftover from an earlier state. I'll remove

dckc · 2024-06-10T15:27:55Z

packages/orchestration/src/proposals/orchestration-proposal.js

@@ -86,6 +108,12 @@ export const getManifestForOrchestration = (_powers, { orchestrationRef }) => ({
        orchestrationVat: 'orchestrationVat',
      },
    },
+    [initChainInfo.name]: {
+      consume: {
+        agoricNames: true,


it's harmless, but why is agoricNames here?

thanks. leftover from an earlier state. I'll remove

dckc · 2024-06-10T15:33:51Z

packages/vats/src/core/chain-behaviors.js

- * @deprecated use reflectAgoricNamesToChainStorage
+ * @deprecated use publishAgoricNamesToChainStorage


that prompted me to realize: adding chain under agoricNames doesn't automatically publish it to vstorage. We need to call E(agoricNames).publishNameHubs(..., ['chain']).

Want to add a test that the chain info is visible from vstorage?

that explains the trouble I was running into.

what happens when a new chain is added, do we need to call publishNameHubs again? I kind of expected agoricNames would auto-update its vstorage using the onUpdate callback. Should it?

confirmed:

agoric-sdk/packages/vats/src/vat-agoricNames.js

Lines 64 to 67 in e193e66

const recorderKit =

await E(vatBoard).makePublishingRecorderKit(kindNode);

kindAdmin.onUpdate(recorderKit.recorder);

}),

Doesn't adding chain to agoricNamesReserved get this auto-updater? I"ll add an explicit test

Once we call E(agoricNames).publishNameHubs(..., ['chain']), each time a chain is added, the whole list of entries in vstorage will get updated. But just doing E(agoricNamesAdmin).provideChild('chain') isn't enough to get the updates started for the new namehub.

dckc · 2024-06-10T15:37:18Z

packages/vats/src/core/utils.js

+  chain: {
+    agoric: 'Agoric chain info',
+  },


Is this used? It suggests that agoricNames had a chain child all along. It might hide the problem that we need to call E(agoricNames).publishNameHubs(..., ['chain']) when running the orchestration-proposal.js core eval.

It suggests that agoricNames had a chain child all along

I was on the fence about this but the js doesn't say anything about bootstrap,

agoric-sdk/packages/vats/src/core/utils.js

Lines 16 to 17 in 96c19f5

* We reserve these keys in name hubs.

*

If it means only reserved before the chain boots, I can take this out but I'd want to include new documentation and probably move these core/utils.js things that are meant only for bootstrap into a module that makes that clear. Please advise.

Note, this is the change that was necessary to make publishNameHubs set up an onUpdate to publish each new entry to vstorage.

0xpatrickdev · 2024-06-10T15:58:51Z

packages/vm-config/decentral-itest-orchestration-config.json

+                {
+                    "interestRateValue": 1000,
+                    "interchainAssetOptions": {
+                        "denom": "ibc/toyatom",


Calling this ibc/toyatom / ATOM will present an issue when using this config for e2e testing with sim chains and relayers.

Is it straightforward to call this something generic like STAKE to prevent the collision?

It will require a lot of other things to change. I'll see if they fit easily into this PR.

The wallet driver depends on that right now,

agoric-sdk/packages/boot/test/bootstrapTests/walletFactory.ts

Line 39 in f880c46

agoricNamesRemotes.brand.ATOM || Fail`ATOM missing from agoricNames`;

This was the status quo so I consider changing it out of scope. Many tests use that so it's worth handling in its own PR or in one that will break because of it.

0xpatrickdev · 2024-06-10T16:05:11Z

packages/vm-config/decentral-itest-orchestration-config.json

+        "@agoric/builders/scripts/vats/init-network.js",
+        "@agoric/builders/scripts/vats/init-localchain.js",
+        "@agoric/builders/scripts/vats/init-transfer.js",
+        "@agoric/builders/scripts/vats/init-transfer.js",


Suggested change

"@agoric/builders/scripts/vats/init-transfer.js",

dckc · 2024-06-10T20:29:11Z

packages/orchestration/src/proposals/orchestration-proposal.js

+  if (!chainStorage) {
+    console.warn('no chain storage, not registering chain info');
+    return;
+  }


sigh; here's hoping we can get rid of this before long

dckc · 2024-06-10T20:33:08Z

packages/orchestration/src/proposals/orchestration-proposal.js

+    Far('chain info writer', {
+      write(entries) {
+        // chainInfo has no cap data but we need to marshal bigints
+        const marshalData = makeMarshal(_val => Fail`data only`);


👍 interesting... no round trip thru board

turadg force-pushed the 9063-init-chainInfo branch from 5014f3e to d90897b Compare June 10, 2024 14:32

turadg marked this pull request as ready for review June 10, 2024 14:38

turadg mentioned this pull request Jun 10, 2024

feat: generic chain with sendAnywhere demo contract #9460

Merged

5 tasks

turadg requested review from dckc and 0xpatrickdev June 10, 2024 14:50

turadg added the force:integration Force integration tests to run on PR label Jun 10, 2024

dckc reviewed Jun 10, 2024

View reviewed changes

0xpatrickdev reviewed Jun 10, 2024

View reviewed changes

turadg force-pushed the 9063-init-chainInfo branch from d90897b to f880c46 Compare June 10, 2024 17:23

turadg requested review from dckc and 0xpatrickdev June 10, 2024 17:44

0xpatrickdev approved these changes Jun 10, 2024

View reviewed changes

turadg added 6 commits June 10, 2024 12:43

test(a3p): enable orchestration

a8eba28

chore(deps): bump a3p's yarn to 4.2.2

169b8c5

refactor: proposal doesn't need vow

80ad3de

refactor: simplify test context type

89a8697

feat: initChainInfo in orchestration setup eval

5913d8f

refactor: vm-config for orchestration

5d4b6fd

turadg force-pushed the 9063-init-chainInfo branch from f880c46 to 5d4b6fd Compare June 10, 2024 19:44

dckc approved these changes Jun 10, 2024

View reviewed changes

turadg added the automerge:rebase Automatically rebase updates, then merge label Jun 10, 2024

mergify bot merged commit 1dcae57 into master Jun 10, 2024
71 checks passed

mergify bot deleted the 9063-init-chainInfo branch June 10, 2024 20:46

turadg mentioned this pull request Jun 10, 2024

cleanup agoricNames publishing #9480

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

9063 init chainInfo #9477

9063 init chainInfo #9477

turadg commented Jun 10, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 10, 2024 •

edited

Loading

dckc Jun 10, 2024

dckc left a comment

dckc Jun 10, 2024

turadg Jun 10, 2024

dckc Jun 10, 2024

turadg Jun 10, 2024

dckc Jun 10, 2024

turadg Jun 10, 2024

dckc Jun 10, 2024

turadg Jun 10, 2024

dckc Jun 10, 2024

turadg Jun 10, 2024

dckc Jun 10, 2024

turadg Jun 10, 2024

turadg Jun 10, 2024 •

edited

Loading

dckc Jun 10, 2024

dckc Jun 10, 2024

turadg Jun 10, 2024 •

edited

Loading

turadg Jun 10, 2024

0xpatrickdev Jun 10, 2024

turadg Jun 10, 2024

turadg Jun 10, 2024

0xpatrickdev Jun 10, 2024

dckc Jun 10, 2024

dckc Jun 10, 2024

		* stakeBld: Installation<
		* import('../../src/examples/stakeBld.contract.js').start

		* @deprecated use reflectAgoricNamesToChainStorage
		* @deprecated use publishAgoricNamesToChainStorage

	const recorderKit =
	await E(vatBoard).makePublishingRecorderKit(kindNode);
	kindAdmin.onUpdate(recorderKit.recorder);
	}),

9063 init chainInfo #9477

9063 init chainInfo #9477

Conversation

turadg commented Jun 10, 2024 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages bot commented Jun 10, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

Choose a reason for hiding this comment

dckc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turadg Jun 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turadg Jun 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turadg commented Jun 10, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 10, 2024 •

edited

Loading

turadg Jun 10, 2024 •

edited

Loading

turadg Jun 10, 2024 •

edited

Loading