Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(liveslots): cache.delete() does not return a useful value #9509

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix(liveslots): cache.delete() does not return a useful value #9509

merged 1 commit into from
Jun 14, 2024

Commits on Jun 14, 2024

  1. fix(liveslots): cache.delete() does not return a useful value 

    Liveslots uses an internal `Cache` utility to hold data about virtual
objects, backed by the vatstore. PR #8752 included a change to make
its `delete()` method return a "did exist" boolean, just like a
JavaScript `Map`. Unfortunately the cache does not know whether a key
is present/absent in the backing store, so `delete()` will return an
erroneous value. It would cost an extra DB query to make this behave
as expected, and liveslots does not have a need for it.

So this commit reverts that change, and makes `delete()` return void
as before.
    @warner
    warner committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    42ea8a3 View commit details
    Browse the repository at this point in the history