agd enforce Node.js version #9623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Jul 1, 2024
Deploying agoric-sdk with
|
| Latest commit: |
5f01bef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://afe57c7e.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mhofman-9622-node-version-ch.agoric-sdk.pages.dev |
turadg
approved these changes
Jul 1, 2024
mhofman
force-pushed
the
mhofman/9622-node-version-check
branch
from
3876ed0
to
5f01bef
Compare
mhofman
pushed a commit
that referenced
this pull request
Jul 1, 2024
refs: #9622 ## Description Enforce the Node.js version in agd builder. Reverts #9619 This enforces LTS range, aka `^18.12` or `^20.9` through a regexp similar to the golang version check. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations We'll need to update release notes for validators to use `agd build` instead of the former `yarn install` and `yarn build` as that may still fail. If they still chose to go that route, they're on their own. ### Testing Considerations CI covers `agd build` ### Upgrade Considerations Smooth the transition away from previously supported Node v16 in upgrade-15
mergify bot
added a commit
that referenced
this pull request
Jul 1, 2024
refs: #9622 ## Description #9623 claimed to enforce Node.js versions ^18.12 or ^20.9, but due to a typo allows arbitrarily high versions to pass the check. This corrects it to enforce that the major version is exactly 18 or 20. ### Security Considerations None. ### Scaling Considerations n/a ### Documentation Considerations Matches the [README](https://github.com/Agoric/agoric-sdk?tab=readme-ov-file#prerequisites). ### Testing Considerations Checked by integration testing in CI. ### Upgrade Considerations Will need an update for supporting Node.js v22 when that enters LTS (ref #9265).
gibson042
pushed a commit
that referenced
this pull request
Jul 1, 2024
refs: #9622 ## Description #9623 claimed to enforce Node.js versions ^18.12 or ^20.9, but due to a typo allows arbitrarily high versions to pass the check. This corrects it to enforce that the major version is exactly 18 or 20. ### Security Considerations None. ### Scaling Considerations n/a ### Documentation Considerations Matches the [README](https://github.com/Agoric/agoric-sdk?tab=readme-ov-file#prerequisites). ### Testing Considerations Checked by integration testing in CI. ### Upgrade Considerations Will need an update for supporting Node.js v22 when that enters LTS (ref #9265).
gibson042
added a commit
that referenced
this pull request
Jul 1, 2024
Rebase todo ``` # Branch fix-vow-include-vat-js-in-package-files-9607- label base-fix-vow-include-vat-js-in-package-files-9607- pick b6ffa6f fix(vow): include vat.js in package files label fix-vow-include-vat-js-in-package-files-9607- reset base-fix-vow-include-vat-js-in-package-files-9607- merge -C a3826e9 fix-vow-include-vat-js-in-package-files-9607- # fix(vow): include vat.js in package files (#9607) # Pull Request #9601 pick 6bc363b fix(cosmos): only allow snapshot export at latest height (#9601) # Branch Force-xsnap-rebuild-9618- label base-Force-xsnap-rebuild-9618- pick 467435a fix(xsnap): force rebuild if build config changes pick a22772e fix(agd): check xsnap was rebuilt pick 2b53896 feat(xsnap): force rebuild if binary version mismatch label Force-xsnap-rebuild-9618- reset base-Force-xsnap-rebuild-9618- merge -C 78b6fec Force-xsnap-rebuild-9618- # Force xsnap rebuild (#9618) # Branch agd-enforce-Node-js-version-9623- label base-agd-enforce-Node-js-version-9623- #pick 4b35caf revert fix: typescript-estree does not support Node.js LTS (#9619) pick 5f01bef fix(agd): force own node.js version check label agd-enforce-Node-js-version-9623- reset base-agd-enforce-Node-js-version-9623- merge -C 4f70e66 agd-enforce-Node-js-version-9623- # agd enforce Node.js version (#9623) # Branch gibson-9623-followup label base-gibson-9623-followup pick 6102eb9 fix: Disallow Node.js major version >20 label gibson-9623-followup reset base-gibson-9623-followup merge -C caaec05 gibson-9623-followup # (upstream/master) fix: Disallow Node.js major version >20 (#9630) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9622
Description
Enforce the Node.js version in agd builder. Reverts #9619
This enforces LTS range, aka
^18.12or^20.9through a regexp similar to the golang version check.Security Considerations
None
Scaling Considerations
None
Documentation Considerations
We'll need to update release notes for validators to use
agd buildinstead of the formeryarn installandyarn buildas that may still fail. If they still chose to go that route, they're on their own.Testing Considerations
CI covers
agd buildUpgrade Considerations
Smooth the transition away from previously supported Node v16 in upgrade-15