9449 chainHub durability #9665
Merged
9449 chainHub durability #9665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
ec65bfa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://39b9a070.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9449-chainhub-durability.agoric-sdk.pages.dev |
turadg
force-pushed
the
9449-chainHub-durability
branch
from
f0b6790
to
769b0af
Compare
mhofman
requested changes
Jul 8, 2024
packages/vow/src/tools.js
Outdated
Comment on lines
53
to
55
| // TODO this needs to be an anonymous durable zone for the watched function | ||
| // Ideally, it should be a lazy one that only allocates the subzone if it gets used | ||
| const fnSubzone = makeHeapZone(`${name} hack subzone`); |
There was a problem hiding this comment.
Let's remove this for now. I am not convinced we need this in the final version
| * @returns {(...args: unknown[]) => Vow<T>} | ||
| */ | ||
| const retriable = | ||
| (fnZone, name, fn) => |
There was a problem hiding this comment.
Wondering if we should put a dummy fnZone.prepareExo here to force the user to call retriable top level, even though that would only let us detect issues during upgrades.
mhofman
requested changes
Jul 9, 2024
mhofman
approved these changes
Jul 9, 2024
turadg
force-pushed
the
9449-chainHub-durability
branch
from
137bfed
to
ec65bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9449
Description
This makes ChainHub return durable vows. The underlying lookup functions are not durable but they made so by the
retriablehelper.So this also introduces a stub version of #9541 pulled from @dtribble 's #9657
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
not yet upgradable. Communicated by
agoric-sdk/packages/vow/src/tools.js
Lines 37 to 38 in a267ba2