Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise multichain testing docs #9737

Merged
merged 2 commits into from
Jul 19, 2024
Merged

revise multichain testing docs #9737

merged 2 commits into from
Jul 19, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Jul 18, 2024

incidental

Description

Some minor clarifications that were helpful to me

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@turadg turadg requested a review from 0xpatrickdev July 18, 2024 22:48
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this in SCM? since the docs say to run override-chain-registry I wonder if we should gitignore this instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should .gitignore this if you wouldn't mind including in the PR

Copy link

cloudflare-workers-and-pages bot commented Jul 18, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 35e25b5
Status:🚫  Build failed.

View logs

Copy link
Member

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should .gitignore this if you wouldn't mind including in the PR

@turadg turadg marked this pull request as ready for review July 19, 2024 17:20
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Jul 19, 2024
@mergify mergify bot merged commit 5d70529 into master Jul 19, 2024
96 of 97 checks passed
@mergify mergify bot deleted the ta/multichain-docs branch July 19, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants