Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add badges for build status, license and auto-wiki #9751

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Jul 22, 2024

incidental

Description

The auto-wiki from Mutable.ai is quite useful. Provide a link: https://wiki.mutable.ai/Agoric/agoric-sdk

While adding that badge I noticed we lacked a couple other important ones so this adds those too.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

nothing more

Testing Considerations

Reviewers, take a look at the rendered README

Upgrade Considerations

none

@turadg turadg requested review from kriskowal and ivanlei July 22, 2024 15:16
Copy link

cloudflare-workers-and-pages bot commented Jul 22, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86c881e
Status: ✅  Deploy successful!
Preview URL: https://e535760f.agoric-sdk.pages.dev
Branch Preview URL: https://ta-mutableai-badge.agoric-sdk.pages.dev

View logs

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.38%. Comparing base (c7eca9b) to head (86c881e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9751   +/-   ##
=======================================
  Coverage   56.37%   56.38%           
=======================================
  Files         667      667           
  Lines      207560   207560           
  Branches      343      339    -4     
=======================================
+ Hits       117022   117024    +2     
+ Misses      90420    90417    -3     
- Partials      118      119    +1     

see 2 files with indirect coverage changes

Copy link
Contributor

@ivanlei ivanlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in preview. 1 copy/paste error it seems.

README.md Outdated Show resolved Hide resolved
@turadg turadg requested a review from ivanlei July 22, 2024 16:39
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Jul 22, 2024
@turadg turadg dismissed ivanlei’s stale review July 23, 2024 21:28

made the requested fix

Comment on lines +5 to +6
![unit tests status](https://github.com/Agoric/agoric-sdk/actions/workflows/test-all-packages.yml/badge.svg)
![integration tests status](https://github.com/Agoric/agoric-sdk/actions/workflows/integration.yml/badge.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently red, fwiw.

@mergify mergify bot merged commit a14b527 into master Jul 23, 2024
79 checks passed
@mergify mergify bot deleted the ta/mutableai-badge branch July 23, 2024 23:37
turadg added a commit to endojs/endo that referenced this pull request Aug 1, 2024
_incidental_

## Description

Prompted by @ivan's discovery in
Agoric/agoric-sdk#9751 (comment)

This README was still pointing to SES-shim CI. I updated it to use the
Github Action badge.

This also adds the badge for the Mutable.ai auto wiki.

### Security Considerations

none
### Scaling Considerations

none

### Documentation Considerations

here

### Testing Considerations

reviewer please look at the rendered output

### Compatibility Considerations

none

### Upgrade Considerations
none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants