fix: giving collateral should not change totalDebt #9873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
e29a42c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2f042bef.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-totaldebt.agoric-sdk.pages.dev |
dckc
force-pushed
the
dc-totalDebt
branch
3 times, most recently
from
a48000c
to
ad65961
Compare
dckc
commented
Aug 14, 2024
| totalDebt += WANT_EXTRA + 29n; // magic number is fees | ||
| totalDebt += WANT_EXTRA + 20n; // magic number is fees |
There was a problem hiding this comment.
@Chris-Hibbert I'm particularly interested in reviewer feedback on the changes in this file.
I just sort of updated them arbitrarily to match the new observed values.
There was a problem hiding this comment.
I pushed e9388a5 to repair the test.
turadg
reviewed
Aug 16, 2024
packages/inter-protocol/test/vaultFactory/vault-collateralization.test.js
Outdated
Show resolved
Hide resolved
turadg
approved these changes
Aug 16, 2024
packages/inter-protocol/test/vaultFactory/vault-collateralization.test.js
Show resolved
Hide resolved
|
|
||
| t.log('charge 2% per day to simulate lower rates over longer times'); | ||
| const aethKey = { collateralBrand: aeth.brand }; | ||
| const twoPctPerDay = run.makeRatio(2n * 360n, 100n); |
There was a problem hiding this comment.
Suggested change
| const twoPctPerDay = run.makeRatio(2n * 360n, 100n); | |
| const twoPctPerDay = run.makeRatio(2n * 365n, 100n); |
| totalDebt += WANT_EXTRA + 29n; // magic number is fees | ||
| totalDebt += WANT_EXTRA + 20n; // magic number is fees |
There was a problem hiding this comment.
I pushed e9388a5 to repair the test.
turadg
previously requested changes
Aug 16, 2024
Comment on lines
355
to
358
| if (oldDen < newDen) { | ||
| return ratio; | ||
| } | ||
|
|
There was a problem hiding this comment.
this is a change in behavior and I think breaks the declared behavior,
Make an equivalant ratio with a new denominator
This function quantize quantizes. Deciding not to quantize is the responsibility of the caller.
|
Feel free to drop the |
dckc
force-pushed
the
dc-totalDebt
branch
2 times, most recently
from
a118019
to
ae42f73
Compare
- use driver to check metrics notifications
When doing `totalDebt += newDebtFor1Vault - oldDebtFor1Vault`, make sure to use the same sort of calculation for old and new.
The verifications for metrics updates were misplaced. Added interest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #XXXX
Description
Updating
totalDebtfor 1vaultwas doingtotalDebt += vault.getCurrentDebt() - oldwhere current debt includes compounded interest but old did not.Security Considerations
This (in combination with another PR to reset totalDebt to the sum over all vaults) should address a confusion risk for metrics clients.
Scaling Considerations
The separate work to reset totalDebt to the sum over all vaults may have some, but I don't see any here.
Testing Considerations
A straightforward unit test is included.
Upgrade Considerations
This change takes effect with the next upgrade to the
vaultFactory.Documentation Considerations
As part of the governance decision to upgrade
vaultFactory, metrics consumers should be notified of this fix.