Ratio.quantize() shouldn't increase precision unnecessarily #9926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
118e6ad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8fefa710.agoric-sdk.pages.dev |
| Branch Preview URL: | https://cth-ratioquantize.agoric-sdk.pages.dev |
Chris-Hibbert
force-pushed
the
cth-ratioQuantize
branch
from
348bd7c
to
694bed1
Compare
turadg
reviewed
Aug 20, 2024
There was a problem hiding this comment.
The potential loss of precision is persuasive. E.g. quantizing 1/3 by 10.
Please update the no longer correct jsdoc:
Make an equivalant ratio with a new denominator
(had a typo too)
In the next push, please squash all commits into one. The test change is necessary for the feat commit alone to pass CI.
| @@ -352,6 +352,10 @@ export const ratiosSame = (left, right) => { | |||
| export const quantize = (ratio, newDen) => { | |||
| const oldDen = ratio.denominator.value; | |||
| const oldNum = ratio.numerator.value; | |||
| if (oldDen < newDen) { | |||
There was a problem hiding this comment.
ignorable nit: testing the param against the status quo reads more conventionally to me
Suggested change
| if (oldDen < newDen) { | |
| if (newDen > oldDen) { |
There was a problem hiding this comment.
very correct.
Chris-Hibbert
force-pushed
the
cth-ratioQuantize
branch
from
694bed1
to
118e6ad
Compare
turadg
approved these changes
Aug 20, 2024
Chris-Hibbert
added
the
automerge:rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ratios are designed to hold fractions as ratios with arbitrary length denominators. A few operations (multiplication) can cause the denominators to grow rapidly. To allow holders of growing ratios to manage this, we provide a method
quantize(), which returns a ratio that approximates the original value, but with a smaller denominator.The current implementation uses the provided denominator even if it is larger. This doesn't gain anything, and can lose precision unnecessarily
Security Considerations
No security implications.
Scaling Considerations
The quantize() method is used to limit the size of very large BigInts. This improvement only makes that better.
Documentation Considerations
No need for changes. The current doc does say "Make an equivalant ratio with a new denominator", even though the result is only an approximation.
Testing Considerations
Added new tests.
Upgrade Considerations
No hurry to get this included in any particular contract upgrade.