Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove erroneous error messages #126

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

samsiegart
Copy link
Contributor

fixes #121

Copy link

cloudflare-workers-and-pages bot commented Aug 30, 2024

Deploying dapp-econ-gov with  Cloudflare Pages  Cloudflare Pages

Latest commit: 167aadf
Status:⚡️  Build in progress...

View logs

Copy link

Cloudflare deployment logs are available here

@samsiegart samsiegart requested a review from turadg August 30, 2024 19:02
@@ -15,7 +15,7 @@ import CharterGuidance from './CharterGuidance';
import DirectorParamChange from './DirectorParamChange';
import PauseVaultDirectorOffers from './PauseVaultDirectorOffers';
import ChangeOracles, { ChangeOraclesMode } from './ChangeOracles';
import BurnIst from './BurnIst';
// import BurnIst from './BurnIst';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove. Should we add a lint rule for unused imports?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. We actually have that already, it's been popping up on PRs:

Screen Shot 2024-08-30 at 1 02 32 PM

@samsiegart samsiegart merged commit fd6eaea into main Aug 30, 2024
2 of 3 checks passed
@samsiegart samsiegart deleted the silence-vstorage-error branch August 30, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

erroneous error messages
2 participants