fix: default to mainnet #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
da384c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f186b5d0.dapp-econ-gov.pages.dev |
| Branch Preview URL: | https://default-mainnet.dapp-econ-gov.pages.dev |
dckc
previously approved these changes
Feb 15, 2024
| const agoricNet = usp.get('agoricNet') || 'devnet'; | ||
| const agoricNet = usp.get('agoricNet') || 'main'; |
There was a problem hiding this comment.
I don't understand the diagnosis that leads to this fix, but it can't hurt much.
otoole-brendan
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Explicitly acknowledging this risk and move that it default to mainnet. It's customer, the EC committee members are exclusively using this against mainnet and very rarely point to test networks so this is an efficiency for them. They are trained to exercise caution when proposing and the risk of accidental proposals are low given a quorum of 4+ would need to similarly vote on it (and I've seen how much they coordinate around these votes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84