WIP: Update fungible-faucet to work with agoric-sdk community-dev #59
Conversation
| @@ -1,5 +1,4 @@ | |||
| // @ts-check | |||
| /* globals window, WebSocket */ | |||
There was a problem hiding this comment.
Looks to me like window at least is still used as a free variable here. Our tools are supposed to at least warn on such variables without this "globals" declaration. This is directly related to the outstanding bug on too much ambient authority.
Do our tools not warn if you get rid of this "globals" directive? That itself is bug. Please file an issue.
There was a problem hiding this comment.
Attn @dckc , our guardian against ambient authority ;)
There was a problem hiding this comment.
Not sure that tool is attached to this repo
There was a problem hiding this comment.
How can we ensure greater tool uniformity among our repos?
There was a problem hiding this comment.
I don't know any short path to get there.
And I think we've drifted pretty far off topic from this PR...
There was a problem hiding this comment.
And I think we've drifted pretty far off topic from this PR...
Agreed!
Summary
Update fungible-faucet to work with agoric-sdk community-dev
Details
Testing