Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PSM functionality into dapp-inter #32

Open
turadg opened this issue Jan 18, 2023 · 5 comments
Open

Merge PSM functionality into dapp-inter #32

turadg opened this issue Jan 18, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request vaults_triage DO NOT USE

Comments

@turadg
Copy link
Member

turadg commented Jan 18, 2023

What is the Problem Being Solved?

PSM is part of the Inter Protocol so dapp-inter needs to provide PSM functionality.

Description of the Design

It's mostly a matter of pulling the components over from dapp-psm. The work of cleanly integrating into the UI but can happen in stages.

We also need a plan for what to do with psm.inter.trade. E.g. whether/how it redirects to a dapp-inter deployment

Security Considerations

Test Plan

@turadg turadg added the enhancement New feature or request label Jan 18, 2023
@samsiegart
Copy link
Collaborator

samsiegart commented Jan 18, 2023

Some service/data level features that will need to be reconciled:

  • Toast provider/service
  • Wallet bridge
  • Keplr connection
  • (Possibly) Marshal context, brand DisplayInfos

Also some likely cosmetic changes such as sharing the connect wallet button, and some color tweaks.

@otoole-brendan
Copy link

punting to Vaults +1 per discussion with @samsiegart. cc @turadg for visibility...this somehow dropped off our radar and wasn't factored into estimates/scheduling and sounds like nice to have so it's punted...shout if any concerns

@turadg
Copy link
Member Author

turadg commented Jan 27, 2023

Ok then we'll need Agoric/dapp-psm#56

@rowgraus rowgraus added the vaults_triage DO NOT USE label Feb 6, 2023
@otoole-brendan
Copy link

Removing from V+1 release for now while we reconcile dapp/FE priorities and triage more intentionally into V+1 release

@otoole-brendan
Copy link

@samsiegart heads up - will be prioritizing this work over coming weeks (merging PSM into app.inter.trade) - will find some time with you to get a pulse on what's involved there

@otoole-brendan otoole-brendan changed the title PSM functionality Merge PSM functionality into dapp-inter Jun 6, 2024
github-actions bot pushed a commit to agoric-labs/dapp-inter that referenced this issue Jul 23, 2024
github-actions bot pushed a commit that referenced this issue Jul 26, 2024
Revert the persistant disk sizes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vaults_triage DO NOT USE
Projects
None yet
Development

No branches or pull requests

4 participants