Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rely on ids not ordering for batch query #143

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix: rely on ids not ordering for batch query #143

merged 1 commit into from
Jun 20, 2023

Conversation

samsiegart
Copy link
Collaborator

@gibson042 Pointed out that the ordering of responses is not guaranteed in batch queries, we should rely on the id field instead

@samsiegart samsiegart marked this pull request as ready for review June 20, 2023 16:45
@samsiegart samsiegart requested a review from turadg June 20, 2023 16:45
@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited
Loading

Network:
Commit: 030de76
Ref: refs/heads/main
IPFS v1 hash: bafybeib4n6m7m44blqb2hg7o6famroqhiepoqfnxhdh6s5xryus4shj5t4
CF - DWeb - 4EVERLAND

turadg
turadg approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Time to put this into ui-kit so changes don't need to be copied across repos?

@samsiegart
Copy link
Collaborator Author

Time to put this into ui-kit so changes don't need to be copied across repos?

It's only in one repo so far, but yea I suppose I'll do that next

@samsiegart samsiegart merged commit 030de76 into main Jun 20, 2023
3 checks passed
@samsiegart samsiegart deleted the use-batch-ids branch June 20, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsiegart @turadg