chore: add SKIP_EXTENSION_SETUP flag to avoid duplicate wallet setup #79
Conversation
| @@ -7,7 +7,7 @@ | |||
| "dev": "vite", | |||
| "build": "tsc && vite build", | |||
| "test": "vitest spec", | |||
| "test:e2e": "EXTENSION=keplr synpress run --configFile=test/e2e/synpress.config.cjs", | |||
| "test:e2e": "SKIP_EXTENSION_SETUP=true EXTENSION=keplr synpress run --configFile=test/e2e/synpress.config.cjs", | |||
There was a problem hiding this comment.
how does the account with the spike siege world rather ... mnemonic get set up?
There was a problem hiding this comment.
Are you trying to set up this account locally, Dan?
There was a problem hiding this comment.
no; I'm trying to understand how test:e2e works when skipping extension set-up.
There was a problem hiding this comment.
Normally, when we don't pass the SKIP_EXTENSION_SETUP flag, it executes the setupWallet method inside the before hook present in this file of @agoric/synpress.
When we pass SKIP_EXTENSION_SETUP and set it to true in test:e2e, the setupWallet function is not executed inside the before hook.
There was a problem hiding this comment.
The implementation for setupWallet is defined over here
It tends to use a hard-coded mnemonic orbit bench unit... if we don't pass secretWords to the setupWallet.
I am going to eliminate this though. Instead of using a hard-coded value, we'll use the one passed via the environment variable. Right now, we accept the environment variable(SECRET_WORDS) for mnemonic but don't use its value. HERE.
We can set up a meeting sometime and discuss this? :) |
In end-to-end test cases, the wallet is set up twice because
@agoric/synpresshas code in thebeforehook that sets up the wallet before running tests. Check the code here.However, since there is a specific test for setting up the wallet in
dapp-offer-upin this file, we can skip the setup done by@agoric/synpressby setting theSKIP_EXTENSION_SETUPenvironment variable to true. This avoids redundant wallet setups.