Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Offer-up Work with GHCS #91

Merged
merged 9 commits into from
Aug 29, 2024
Merged

Conversation

amessbee
Copy link
Contributor

@amessbee amessbee commented Aug 8, 2024

Changes include:

  • script to make ports visible
  • .devcontainer directory and file
  • addition of env variables for domain and codespace name
  • fix RPC and API ENDPOINTS in UI for wallet connection
  • instructions addition in README

@amessbee amessbee force-pushed the ms/Making-proj-work-with-GHCS branch from ff9b03c to 98a9703 Compare August 8, 2024 16:09
@amessbee amessbee added the enhancement New feature or request label Aug 8, 2024
@amessbee
Copy link
Contributor Author

@rabi-siddique can you please review this. @mujahidkay has already tested it, and I think we can merge it after you get to test it and find it reasonably stable. I added a few instructions in main README.md apart from other GHCS related changes. Thanks.

@amessbee amessbee marked this pull request as ready for review August 16, 2024 09:30
ui/src/App.tsx Outdated Show resolved Hide resolved
@rabi-siddique
Copy link
Contributor

rabi-siddique commented Aug 16, 2024

Getting CORS error while connecting to the wallet when using codespace:
image

@rabi-siddique
Copy link
Contributor

rabi-siddique commented Aug 16, 2024

My bad. I did not make the ports public. After making the ports public, I was able to connect the wallet and make the offer. There was an element of flakiness too but I am assuming it was due to my Internet. Will give it another try in a while.

Looks good overall :)

@amessbee amessbee merged commit 1f6449f into main Aug 29, 2024
3 checks passed
@amessbee amessbee deleted the ms/Making-proj-work-with-GHCS branch August 29, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants