-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making Offer-up Work with GHCS #91
Conversation
ff9b03c
to
98a9703
Compare
@rabi-siddique can you please review this. @mujahidkay has already tested it, and I think we can merge it after you get to test it and find it reasonably stable. I added a few instructions in main README.md apart from other GHCS related changes. Thanks. |
My bad. I did not make the ports public. After making the ports public, I was able to connect the wallet and make the offer. There was an element of flakiness too but I am assuming it was due to my Internet. Will give it another try in a while. Looks good overall :) |
Changes include:
.devcontainer
directory and file