-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid Plugin: Render Inline Mermaid #1243
base: main
Are you sure you want to change the base?
Conversation
Deploying documentation with Cloudflare Pages
|
Cloudflare deployment logs are available here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deleted image has a reference in other files:
documentation/main/guides/orchestration/contract-walkthroughs/cross-chain-unbond.md
Lines 3 to 4 in c1e76b7
<!-- XXX the diagram below is a useful part of the page but it needs to be updated before it is uncommented. --> | |
<!-- ## Overview Diagram |
Please update the comment or not delete the image if the comment is important and we want to bring the image back in the future. If I were you, I would not add mermaid of the deleted image, and instead undelete the file to merge the original PR as soon as possible.
Do you think I should undelete other two unused SVG files too? Since, this is not the topic of the current PR, I guess we can keep them and create a separate PR of deleting unused assets? |
Changes include:
adding mermaid and mermaid vite plugin
update to sequence diagram on orchestration to use inline mermaid
Ref(s):