Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added min and max rows to LFOM expert inputs #280

Merged
merged 5 commits into from
Oct 8, 2020
Merged

Added min and max rows to LFOM expert inputs #280

merged 5 commits into from
Oct 8, 2020

Conversation

fletchapin
Copy link
Member

Introduced two attributes to the LFOM class: min_row_n and max_row_n so the algorithm is easier to configure

HannahSi
HannahSi previously approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@HannahSi HannahSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you Fletcher!

@HannahSi HannahSi merged commit a28dd03 into master Oct 8, 2020
@fletchapin fletchapin deleted the fletch/LFOM_EI branch December 4, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannahSi HannahSi HannahSi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fletchapin @HannahSi