Gradual typing #1217
Gradual typing #1217
Conversation
akaihola
force-pushed
the
gradual-typing
branch
from
32341d4
to
7055239
Compare
| @@ -35,7 +38,7 @@ class CoderPrompts: | |||
| " stop and wait for your approval." | |||
| ) | |||
|
|
|||
| repo_content_prefix = """Here are summaries of some files present in my git repository. | |||
| repo_content_prefix: str | None = """Here are summaries of some files present in my git repository. | |||
There was a problem hiding this comment.
The type union syntax X | Y is only available in Python 3.10, but Aider still supports Python 3.9.
Instead, this should be
| repo_content_prefix: str | None = """Here are summaries of some files present in my git repository. | |
| repo_content_prefix: typing.Optional[str] = """Here are summaries of some files present in my git repository. |
There was a problem hiding this comment.
On line 1 of this file, I've added
from __future__ import annotationswhich makes sure X | Y is supported on Python 3.9.
akaihola
force-pushed
the
gradual-typing
branch
from
7055239
to
8058187
Compare
|
I would think that typing an untyped python codebase is exactly the kind of thing that Aider itself would be great at. Typing the edges is trivial, that leads to type errors, fix those, that leads to new type errors, fix those, etc. I also think if it's worth adding type annotations at all, then it's worth bumping to a Python version that supports the latest / greatest versions of them. Aider seems like more of an end-user thing than infrastructure library, seems okay for it to be more aggressive in bumping requirements than a typical library. |
|
Amazing work as this will make aider improving itself even better (from experience llms do quite well with typed code) |
akaihola
force-pushed
the
gradual-typing
branch
3 times, most recently
from
26f0d2a
to
0f49a3d
Compare
- skip some directories - skip 3rd party packages without typing or type stubs - allow untyped globals and class attributes - don't check untyped functions and methods
akaihola
force-pushed
the
gradual-typing
branch
from
0f49a3d
to
6416497
Compare
|
|
Here's another stab at adding typing since #639 was closed.
I acknowledge that Paul has expressed that he isn't currently planning to add type hints, and that reviewing type hints would be a burden.
However, I believe this extremely minimal Mypy configuration and a minimal set of changes not only make Mypy pass, but also enable to use it to check some types, and allow development to continue without requiring full type hints everywhere.
Mypy takes over the burden of reviewing type annotations from humans.
Most notably, functions with no type hints are not checked by Mypy at all with this configuration. This allows adding type hints just only to select sections of the code base. It is still of course possible to gradually add typing overall and increase Mypy's strictness if desired.
See Using mypy with an existing codebase for more information.