Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor voiceNext issue #396

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Fix minor voiceNext issue #396

merged 6 commits into from
Nov 21, 2023

Conversation

Licho1
Copy link
Contributor

@Licho1 Licho1 commented Nov 20, 2023

Description

This PR fixes issue, where if bot joins a channel that already has people, and those people speak, their voice stutters first time they talk and is ok next time.

It happens because discord sends player joined event only AFTER person stops speaking first time. This means we don't have entry in _transmittingSsrCs and current logic kept recreating it on every packet leading to wrong gap/invalid order packet logic.

This PR also fixes naming issues (which exists in current repo) be labeled as errors (problem in jetbrains rider for example) and fixes DiscordUser comparison for nullable references.

Also voice next native auto copies dlls to bin for easier local testing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested by using voice from the bot with another project.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Licho1 Licho1 requested review from NyuwBot, Lulalaby and a team as code owners November 20, 2023 22:32
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2023

CLA assistant check
All committers have signed the CLA.

@NyuwBot NyuwBot added dependencies Pull requests that update a dependency file core Changes something in core labels Nov 20, 2023
@Lulalaby
Copy link
Member

The nullability is in rework in #341, but we accept it for now, since it doesn't harm.
Many thanks for taking the time for the annoying voicenext topic.

@Lulalaby Lulalaby merged commit 99575b8 into Aiko-IT-Systems:main Nov 21, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes something in core dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

5 participants