Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiving adalight over serial crashes ESP 8266 and 32 #2618

Closed
1 task done
apophisnow opened this issue Apr 4, 2022 · 8 comments
Closed
1 task done

Receiving adalight over serial crashes ESP 8266 and 32 #2618

apophisnow opened this issue Apr 4, 2022 · 8 comments
Labels
bug cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details

Comments

@apophisnow
Copy link

apophisnow commented Apr 4, 2022

What happened?

Adalight over serial causes boards to crash.

To Reproduce Bug

To replicate, use LedFX to send adalight data over a serial connection to ESP 8266 or ESP 32 board. Board will crash and reboot after a short period of time. Baud rate has no impact. Multiple boards were tried.

Expected Behavior

Serial data should not cause board crashes.

Install Method

Binary from WLED.me

What version of WLED?

0.13.1

Which microcontroller/board are you seeing the problem on?

ESP8266, ESP32

Relevant log/trace output

No response

Anything else?

Using https://github.com/dmadison/Adalight-FastLED/blob/master/Arduino/LEDstream_FastLED/LEDstream_FastLED.ino I have no issues with boards crashing when receiving data from LedFX, but no luck when running WLED.

Adalight confirmed working on build 0.13.0b6 but is broken in latest build 0.13.1

Code of Conduct

  • I agree to follow this project's Code of Conduct
@apophisnow apophisnow added the bug label Apr 4, 2022
@Aircoookie
Copy link
Owner

Thank you for reporting this!
How many LEDs are you sending via Adalight?

@apophisnow
Copy link
Author

apophisnow commented Apr 4, 2022 via email

@Bene2103
Copy link

Bene2103 commented Apr 6, 2022

I experienced this behaviour too. But i downgraded to 0.13.0b6.

I also use Adalight protocol but with boblight. In my setup i have 220 LED's.

Thanks for your support!

@sh00bx
Copy link

sh00bx commented Jun 20, 2022

Same here on 0.13.1 release.
Already setting custom baud rate reliably crashes my ESP32s, unlike on ESP8266.
Manually setting baud rate on 0.13.0b6 code not affected

might be #2517 related

sh00bx added a commit to sh00bx/WLED that referenced this issue Jun 26, 2022
- wled_serial.cpp dumbed down to basic adalight functionality only (removed serial out, baudrate customization, improv and tpm2)
- FastLED.show() instead of strip.show()
- hardcoded adalight serial baudrate @921600 in wled.cpp / wled_serial.cpp
@sh00bx
Copy link

sh00bx commented Jun 26, 2022

I've created a hacky workaround for this issue on latest, making these changes:

  • wled_serial.cpp dumbed down to basic adalight functionality only (removed serial out, baudrate customization, improv and tpm2)
  • FastLED.show() instead of strip.show() in wled_serial.cpp
  • hardcoded adalight serial baudrate @921600 in wled.cpp / wled_serial.cpp

See sh00bx-adalight-workaround

No more crashes with these modifications on 0.13.2a0 but to my surprise this did not also resolve another issue I have with adalight on serial, glitches in conjunction with wifi. But I'll open a separate issue on that.

@softhack007 softhack007 added the stale This issue will be closed soon because of prolonged inactivity label Jan 12, 2023
@softhack007 softhack007 added the cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details label Sep 6, 2023
@stale stale bot removed the stale This issue will be closed soon because of prolonged inactivity label Sep 6, 2023
@blazoncek
Copy link
Collaborator

If the issue persists in 0.14.0-b6 or later please reopen the issue.

@blazoncek blazoncek closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2023
@AZDane
Copy link

AZDane commented Oct 1, 2023

I see this behavior in 14.0b6. Using ESP32.

@d3d9
Copy link

d3d9 commented Jun 3, 2024

Can this be reopened as it still occurred on v0.14.0-b6 in October and for me just now on v0.14.4?

I am using an ESP 8266 with 32 pixels and previously used DDP over wifi from LedFx. Now I wanted to try adalight/serial.
This stops working after 1 or 2 seconds. Using one of the diagnostic LedFx effects like Metro or Pixels I could avoid the crash, but switching to something that lights up more pixels in different ways causes the crash almost instantly.
Though I'm not sure if crash is the right term. The WLED uptime doesn't get reset. It just doesn't react to further serial input at all until WLED is restarted. Which further details can I provide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details
Projects
None yet
Development

No branches or pull requests

8 participants