-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WLED PixelArtCreator #3042
WLED PixelArtCreator #3042
Conversation
* pulser bugfix: " % cols" was missing so the effect would simply run out of visible range * float math: use optimized functions: sqrtf, fabsf * two more comments where code could be optimized, but I'm not sure what is thecorrect solution
GoL mutations. cleanup.
This is now properly implemented for inclusion with WLED including updated web server. |
Modified to shave some bytes, adjusted the look to be more in-line with UI and fixed all inlining issues. |
- Changed rendering of large preview image
After editing JSON in textarea field and sending the changed content to device, originally created JSON is sent instead, not the modified one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove minified html dump from cdata.json
You may keep changes in your local file just don't include it in PR.
Better. |
It looks like converter is no longer working for me when IP address is not entered/specified. |
Good input, your type of user is not the user I have in mind when building 😁 Some background and then suggested solutions to get you what you want. It looks like converter is no longer working for me when IP address is not entered/specified. the IP address replaced by wled.local There is also no console error or other message displayed. Development use case explanation Open PAC (possibly by clicking a link in WLED UI) --> Drag or select your file --> Click send. I can see the use cases from a developer/testing/tinkering perspective, so any adjustments should be done in dev mode only. Suggested short term solution: Manually add some character in the IP/host field and PAC will work exactly as you want it. Long term (i.e. when I have time to sit down with this again, like in a day or two 😉)
I can see we have two very different, and conflicting use cases. The "everyday" user that is interested in getting things to just work, and the tinkerer/tester/developer that wants manual control, flexibility and insight into every detail. I can see both perspectives as valid. I've developed this tool mainly for the first category, but I think your suggestions makes sense in a dev-setting. I'll look into implementing your suggestions there. ASAP. Please keep in mind: Any developer of WLED is most likely not the intended user of PAC. Rather the user of WLED is. |
Haha, good point(s). I would recommend to not add developer functionality (and possibly remove |
LOL... Changed my reply after some thought. TBH I totally agree on the dev thing once ready. If you are a dev, you could make your own copy of PAC locally and change the code to spit out anything you like. Comment on my edits if you disagree. |
No description provided.