-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow 2D panel to be larger than 256px in both dimensions #4044
base: main
Are you sure you want to change the base?
Conversation
The use of |
Interesting, what's the purpose and what this change will break? |
If you want this to be included, modify to be ESP32 only. |
@lexszero please clarify how you tested your proposed modification. Did you check that all 2D effects work as before? What about effects like drip or popcorn, which have a special "column mode" when bar is selected as mapping? I would expect that some 2D effects - like octopus or crazy bee - will not work when rows or cols is greater than 255. |
@lexszero important: please rebase your PR to our |
After a quick look, there is a lot more work to be done if you really want to use panels with more than 256 pixels in one dimension. For example
In total, I think this PR is just the beginning of a longer journey... and the core team definitely cannot do it without volunteers helping us. |
Increase MAX_LEDS_PER_BUS and change width and height type in WS2812FX class to uint16_t from uint8_t, which overflowed when attempted to configure a panel larger than 255 pixels.