Decide startup readiness based on the highest record offset #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
force-pushed
the
jjaakola-aiven-use-highest-offset-in-readiness-check
branch
5 times, most recently
from
79e9e73
to
254c2bc
Compare
Karapace relied on poll to return empty topic-messages dictionary. This change will mark state to be ready when the highest offset is catched up.
jjaakola-aiven
force-pushed
the
jjaakola-aiven-use-highest-offset-in-readiness-check
branch
from
254c2bc
to
e9902ce
Compare
tvainika
approved these changes
Nov 4, 2022
tvainika
deleted the
jjaakola-aiven-use-highest-offset-in-readiness-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Karapace relied on poll to return empty topic-messages dictionary and set the state to ready. This PR changes the logic to follow the highest known offset for readiness. When highest offset is catched, state is set ready.
Beginning offset is also tracked in startup. This is to handle case where compaction or purging has removed offset
0.