fix: Karapace instance primary eligiblity added to group protocol #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
9b6cbbc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://66b28782.karapace.pages.dev |
| Branch Preview URL: | https://jjaakola-aiven-fix-primary-e.karapace.pages.dev |
tvainika
reviewed
Dec 9, 2022
There was a problem hiding this comment.
I can see that this is kind of minimal changes needed to fix the issue found. However what about considering also method naming and signatures while we go? I find it confusing that we have get_identity and get_identity_url which I mix with each other, or is it just me? Second note is about type signature (return type) of get_identity_url: It has two modes with one returning json and another dict. What about separating those cases so that one can add valid return type annotation?
Group coordinator leader is selected from the whole set of members of the group. This can also be member that is not primary eligible. This change corrects the group protocol data and Karapace primary selection to use the actual instance configured primary eligibility. The code before used the primary eligibility of the selected group leader which can be false.
jjaakola-aiven
force-pushed
the
jjaakola-aiven-fix-primary-eligibility-assigment
branch
from
0c53b96
to
f9fefcc
Compare
|
Removed the dual-return-type. |
|
Added also typing, not perfect some casts left. The configuration should be moved to dataclass from plain dictionary/JSON. |
tvainika
approved these changes
Dec 12, 2022
tvainika
deleted the
jjaakola-aiven-fix-primary-eligibility-assigment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Group coordinator leader is selected from the whole set of members of the group. This can also be member that is not primary eligible. This change corrects the group protocol data and Karapace primary selection to use the actual instance configured primary eligibility. The code before used the primary eligibility of the selected group leader which can be false.