fix: reset watch of authfile after delete event #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
3e2f0a8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6329e5e1.karapace.pages.dev |
| Branch Preview URL: | https://giuseppelillo-rewatch-auth-f.karapace.pages.dev |
giuseppelillo
force-pushed
the
giuseppelillo/rewatch-auth-file-after-delete-event
branch
from
304ddea
to
3e2f0a8
Compare
giuseppelillo
changed the title
giuseppelillo
changed the title
jjaakola-aiven
deleted the
giuseppelillo/rewatch-auth-file-after-delete-event
branch
aiven-anton
reviewed
Jan 26, 2023
Comment on lines
+94
to
+96
| changes_by_filename = defaultdict(set) | ||
| for change, filename in changes: | ||
| changes_by_filename[filename].add(change) |
There was a problem hiding this comment.
It looks a bit odd to me to be dealing with multiple filenames here, when we're only ever interested in a single one.
Perhaps instead we could just flatten the data into a set for only the interesting file?
changes = {
change
for change, filename in changes
if self._auth_filename in filename
}
if not changes:
continueI think we'd then be able to skip the for loop and conditional guarding self._load_authfile() too?
This would also allow simplifying the raise StopIteration into just break, I think?
aiven-anton
reviewed
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
awatchdisables file watching if a delete event for that file is issued. This may result in the impossibility to read new users and permissions data if the authfile is replaced.Why this way
Resetting file watch after delete event allows notifications related to the new file to be received.