Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Avro enum compatibility handling #535

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

tvainika
Copy link
Contributor

@tvainika tvainika commented Feb 9, 2023

About this change - What it does

Fix Avro enum symbol addition and removal compatibility handling. Karapace has been ignoring those incompatibilities for unknown historical reason. Improve compatibility result logging to be more informative.

Fixes #524

Fix Avro enum symbol addition and removal compatibility handling.
Karapace has been ignoring those incompatibilities for unknown
historical reason.  Improve compatibility result logging to be more
informative.

Fixes #524
@tvainika tvainika requested review from a team as code owners February 9, 2023 07:59
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f19ee9
Status: ✅  Deploy successful!
Preview URL: https://1082a9d8.karapace.pages.dev
Branch Preview URL: https://fix-avro-enum-compatibility.karapace.pages.dev

View logs

@jjaakola-aiven jjaakola-aiven merged commit 4d20d48 into main Feb 10, 2023
@jjaakola-aiven jjaakola-aiven deleted the fix-avro-enum-compatibility branch February 10, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible enum changes are allowed even in FULL compatibility Mode
2 participants