Handle errors while producing backup restoration messages #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
a543250
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a58ebe8e.karapace.pages.dev |
| Branch Preview URL: | https://giuseppelillo-restore-backup.karapace.pages.dev |
giuseppelillo
changed the title
giuseppelillo
force-pushed
the
giuseppelillo/restore-backup-message-error-handling
branch
from
122ad8f
to
a742d84
Compare
giuseppelillo
force-pushed
the
giuseppelillo/restore-backup-message-error-handling
branch
from
a742d84
to
a543250
Compare
tvainika
approved these changes
Feb 15, 2023
tvainika
deleted the
giuseppelillo/restore-backup-message-error-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Backup restoration messages that are produced to the restored topic are currently sent in a fire-and-forget fashion. This PR modifies this behaviour, waiting for the produce action to complete and raising an error if the send was not successful.
Why this way
An error is raised if the produce action was not successful, allowing the caller to know that something went wrong.