fix: do not override SASL mechanism for user REST proxy #620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
If
sasl_mechanism
already defined in the config - do not override it withPLAIN
.Our Kafka installation allows SCRAM authentication only, so current code leads to failed authentication. Preferred mechanism already stated in the config, so let's use it for the user proxy.
Why this way
config["sasl_mechanism"]
default value isNone
, so let's check for it. I'm not sure if we can remove this line completely and rely on that undefined SASL mechanism often meansPLAIN
. This is the most safe patch - keeping existing behavior.