Validated imports for known types #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvainika
force-pushed
the
protobuf-import-check
branch
from
550169f
to
bbe0d6d
Compare
Deploying with
|
| Latest commit: |
5770869
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cb737af5.karapace.pages.dev |
| Branch Preview URL: | https://protobuf-import-check.karapace.pages.dev |
aiven-anton
previously approved these changes
May 26, 2023
| @@ -79,9 +70,6 @@ ignore_errors = True | |||
| [mypy-karapace.protobuf.enum_constant_element] | |||
| ignore_errors = True | |||
|
|
|||
| [mypy-karapace.protobuf.compare_result] | |||
| ignore_errors = True | |||
|
|
|||
Validate that referred known types are imported before use. Also improve typing and mypy purity a bit.
tvainika
force-pushed
the
protobuf-import-check
branch
from
bbe0d6d
to
5770869
Compare
aiven-anton
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Validate that referred known types are imported before use. Also improve typing and mypy purity a bit.
This addresses partially: #626
Why this way
This is compatible behaviour with other protobuf implementations.