Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: harden the order of keys that needs to be serialized #816

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eliax1996
Copy link
Contributor

Why this way

Previously we were relying on the fact that the .keys() order and the json.dumps() order are always sync. This enforces by the OrderedDict a fixed order. Not sure if the same odering check should be performed also for the is_key_in_canonical_format, probably here we want to ensure that the current dict has exactly the same order in the keys().

@eliax1996 eliax1996 force-pushed the eliax1996/ensure-canonical-format-of-keys-is-stable branch 2 times, most recently from ef899bd to c313d24 Compare February 13, 2024 09:52
@eliax1996 eliax1996 force-pushed the eliax1996/ensure-canonical-format-of-keys-is-stable branch from c313d24 to 2f19386 Compare February 13, 2024 10:00
@eliax1996 eliax1996 marked this pull request as ready for review June 19, 2024 07:36
@eliax1996 eliax1996 requested review from a team as code owners June 19, 2024 07:36
@eliax1996
Copy link
Contributor Author

Need to do the same for the canonical format

@eliax1996 eliax1996 marked this pull request as draft June 19, 2024 07:50
Copy link
Contributor

@jjaakola-aiven jjaakola-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants