422 instead of 500 on subject schema error #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvainika
reviewed
Mar 12, 2024
aiven-anton
reviewed
Mar 12, 2024
gpkc
force-pushed
the
subject-invalid-schema
branch
from
9764cec
to
4a0c21c
Compare
tvainika
previously approved these changes
Mar 12, 2024
aiven-anton
approved these changes
Mar 12, 2024
aiven-anton
reviewed
Mar 12, 2024
aiven-anton
requested changes
Mar 12, 2024
gpkc
force-pushed
the
subject-invalid-schema
branch
from
4a0c21c
to
82a7c44
Compare
aiven-anton
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user sends a bad schema, we return a 500 even though the error is handled.
Here we return a 422 instead.