fix: Restore pip-compile invocation #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In eb9ee31, pip-compile was changed to no longer cd into the requirements directory. The reason for this change was because of the use of `ONESHELL` which causes diverging behavior in environments with make versions that don't yet support this mode. This commit reverts the removal of the `cd` invocations, and additionally removes the `ONESHELL` option which should make behavior aligned across dev envs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In eb9ee31, pip-compile was changed to no longer cd into the requirements directory. The reason for this change was because of the use of
ONESHELLwhich causes diverging behavior in environments with make versions that don't yet support this mode.This commit reverts the removal of the
cdinvocations, and additionally removes theONESHELLoption which should make behavior aligned across dev envs.About this change - What it does
References: #xxxxx
Why this way