Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add systemd journal logging configuration #946

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

jjaakola-aiven
Copy link
Contributor

@jjaakola-aiven jjaakola-aiven commented Sep 12, 2024

About this change - What it does

Add configurability for logging handlers. The supported handlers are StreamHandler and systemd.journal.JournalHandler.
The log level is preserved for journal as log is written in structured format for journald.

Requires #947 first.

References: #xxxxx

Why this way

@jjaakola-aiven jjaakola-aiven requested review from a team as code owners September 12, 2024 14:17
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-add-systemd-journal-logging-config branch 28 times, most recently from 884f19d to e0f5304 Compare September 13, 2024 11:32
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-add-systemd-journal-logging-config branch 9 times, most recently from ff223f8 to 749fcd0 Compare September 17, 2024 08:24
@jjaakola-aiven jjaakola-aiven marked this pull request as draft September 18, 2024 06:27
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-add-systemd-journal-logging-config branch 2 times, most recently from 0337e7f to 618ab23 Compare September 30, 2024 09:30
Copy link

github-actions bot commented Sep 30, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace
  config.py
  karapace_all.py 33-35, 39-41, 52-53
Project Total  

This report was generated by python-coverage-comment-action

@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-add-systemd-journal-logging-config branch from 618ab23 to 3b06e6d Compare October 1, 2024 07:58
@jjaakola-aiven jjaakola-aiven marked this pull request as ready for review October 2, 2024 06:20
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-add-systemd-journal-logging-config branch from 3b06e6d to a7d45b8 Compare October 4, 2024 08:23
eliax1996
eliax1996 previously approved these changes Oct 8, 2024
Copy link
Contributor

@eliax1996 eliax1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the comments that are optional/non blocking LGTM

@eliax1996 eliax1996 merged commit 2507dee into main Oct 9, 2024
9 checks passed
@eliax1996 eliax1996 deleted the jjaakola-aiven-add-systemd-journal-logging-config branch October 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants