Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Session Manager Configuration's broken links in README #1625

Merged
merged 2 commits into from
Sep 28, 2016

Conversation

vishrutshah
Copy link
Contributor

No description provided.

@vishrutshah vishrutshah changed the title Fix Session Manager Configuration links in README Fix Session Manager Configuration's broken links in README Sep 27, 2016
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you get the updates made we'll gladly merge this. Thanks for finding the fact that the links are broken!

@@ -360,7 +360,7 @@ Alamofire.request("https://httpbin.org/get").validate().responseJSON { response

Response Caching is handled on the system framework level by [`URLCache`](https://developer.apple.com/reference/foundation/urlcache). It provides a composite in-memory and on-disk cache and lets you manipulate the sizes of both the in-memory and on-disk portions.

> By default, Alamofire leverages the shared `URLCache`. In order to customize it, see the [Session Manager Configurations](#session-manager-configurations) section.
> By default, Alamofire leverages the shared `URLCache`. In order to customize it, see the [Session Manager Configurations](#advanced-usage) section.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be session-manager instead of advanced-usage throughout this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Thanks for the feedback. Updated PR 👍

@cnoon
Copy link
Member

cnoon commented Sep 28, 2016

Sweet! Thanks @vishrutshah! 🍻

@cnoon cnoon merged commit 8191326 into Alamofire:master Sep 28, 2016
@cnoon cnoon self-assigned this Sep 28, 2016
@cnoon cnoon added this to the 4.1.0 milestone Sep 28, 2016
@vishrutshah vishrutshah deleted the session_manager_advance_use branch September 28, 2016 04:35
bdonkey added a commit to bdonkey/Alamofire that referenced this pull request Oct 23, 2016
* 'master' of github.com:Alamofire/Alamofire: (26 commits)
  [Issue Alamofire#1672] Added Request retryCount property to support RequestRetrier.
  Fixed test target compiler warning by not requiring app extension APIs only.
  [PR Alamofire#1670] Fixed compiler issue with DownloadRequest in AF4 migration guide.
  SPM package file now excludes tests since current configuration is not supported.
  Pulled in the release notes for the 3.5.1 release into the CHANGELOG.
  Added docstrings and note to README about resumeData and background sessions.
  Add 10.12 check for tests results, as macOS results are now correct.
  Added missing dashes in CHANGELOG…no functional changes.
  [PR Alamofire#1633] Fixed sample code in the README where error was used incorrectly.
  [PR Alamofire#1625] Fixed Session Manager internal links in the README.
  [PR Alamofire#1615] Fixed compiler error in response validation sample code in README.
  Added release notes to the CHANGELOG and bumped the version to 4.0.1.
  Removed excess whitespace from some of the docstrings…no functional changes.
  Removed framework and test target overrides that duplicated project settings.
  [PR Alamofire#1612] Fixed compilation issue in response handler section of the README.
  Fixed up if statement formatting…no functional changes.
  Added test verifying download request can be resumed with resume data.
  [Issue Alamofire#1551] Fixed retain cycle when using Validation clsoures.
  Fixed alignment in Travis yaml file…no functional changes.
  [PR Alamofire#1520] Renamed OSX to macOS throughout the project.
  ...
bdonkey added a commit to bdonkey/Alamofire that referenced this pull request Nov 1, 2016
* 'master' of github.com:Alamofire/Alamofire: (27 commits)
  [PR Alamofire#1721] Improve embedded framework installation instructions.
  [PR Alamofire#1722] Update README for proper error checking in download.
  [Issue Alamofire#1672] Added Request retryCount property to support RequestRetrier.
  Fixed test target compiler warning by not requiring app extension APIs only.
  [PR Alamofire#1670] Fixed compiler issue with DownloadRequest in AF4 migration guide.
  SPM package file now excludes tests since current configuration is not supported.
  Pulled in the release notes for the 3.5.1 release into the CHANGELOG.
  Added docstrings and note to README about resumeData and background sessions.
  Add 10.12 check for tests results, as macOS results are now correct.
  Added missing dashes in CHANGELOG…no functional changes.
  [PR Alamofire#1633] Fixed sample code in the README where error was used incorrectly.
  [PR Alamofire#1625] Fixed Session Manager internal links in the README.
  [PR Alamofire#1615] Fixed compiler error in response validation sample code in README.
  Added release notes to the CHANGELOG and bumped the version to 4.0.1.
  Removed excess whitespace from some of the docstrings…no functional changes.
  Removed framework and test target overrides that duplicated project settings.
  [PR Alamofire#1612] Fixed compilation issue in response handler section of the README.
  Fixed up if statement formatting…no functional changes.
  Added test verifying download request can be resumed with resume data.
  [Issue Alamofire#1551] Fixed retain cycle when using Validation clsoures.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants