Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove syncResult and replace DispatchQueue.sync #1893

Merged
merged 1 commit into from
Jan 14, 2017
Merged

Remove syncResult and replace DispatchQueue.sync #1893

merged 1 commit into from
Jan 14, 2017

Conversation

Alexander-Ignition
Copy link
Contributor

Remove syncResult<T>(_ closure: () -> T) -> T from DispatchQueue+Alamofire
and replace sync<T>(execute work: () throws -> T) rethrows -> T from Dispatch.

@cnoon cnoon self-requested a review January 14, 2017 01:24
@cnoon cnoon self-assigned this Jan 14, 2017
@cnoon cnoon added this to the 4.3.0 milestone Jan 14, 2017
cnoon
cnoon approved these changes Jan 14, 2017
View reviewed changes
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @Alexander-Ignition!

@cnoon cnoon merged commit f8e719e into Alamofire:master Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnoon cnoon cnoon approved these changes

Assignees

@cnoon cnoon

Labels
async operation
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexander-Ignition @cnoon