Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Error mapping functions to Response types #2361

Merged
merged 8 commits into from
Nov 27, 2017
Merged

Add Error mapping functions to Response types #2361

merged 8 commits into from
Nov 27, 2017

Conversation

jshier
Copy link
Contributor

@jshier jshier commented Nov 20, 2017

Issue Link 🔗

#2306

Goals ⚽

This PR adds mapError and flatMapError to DataResponse and DownloadResponse.

Implementation Details 🚧

Nothing special, just a straightforward porting of the functionality, similar to the previous map and flatMap

Testing Details 🔍

Tests added for the additional API.

@jshier jshier changed the title Functional api sync Add Error mapping functions to Response types Nov 20, 2017
@jshier jshier changed the base branch from master to readme-refactor November 20, 2017 01:57
@jshier jshier changed the base branch from readme-refactor to master November 20, 2017 02:11
@jshier jshier changed the base branch from master to alamofire5 November 27, 2017 05:08
@jshier jshier changed the base branch from alamofire5 to master November 27, 2017 05:08
@jshier jshier merged commit 0a34b44 into master Nov 27, 2017
@jshier jshier deleted the functional-api-sync branch November 27, 2017 05:09
@jshier jshier added this to the 4.6.0 milestone Dec 4, 2017
@groue groue mentioned this pull request Dec 21, 2017
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jshier