-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing boundary string in upload:multipartFormData callback #2705
Allow changing boundary string in upload:multipartFormData callback #2705
Conversation
Thanks for the PR! Can you explain why you want this change? Additionally, since this would be newly mutable, we'd want some relevant tests over the functionality. |
Hi @ondrejstocek, I'm going to go ahead and close this PR out for now since we haven't heard back. We don't want to keep these PRs open forever if we can help it. If you comment back on why this should be re-opened at some point, we can get it opened back up and pushed to Cheers. 🍻 |
Hello @cnoon, |
Thank you for that explanation @ondrejstocek, that does indeed make sense. I'm going to re-open this PR and work to get it through today. |
Okay @ondrejstocek, @jshier and I decided that we're going to push this change out in AF 4.x (will ship in 4.8.2), and that we're going to re-think the upload APIs around I'm going to go ahead and close this PR out for now, and I'll link the new PR in AF5 that addresses this issue just for visibility. Cheers. 🍻 |
Hi @ondrejstocek, I just pushed up #2764 which is a better long-term solution to this issue. We're also considering moving |
Goals ⚽
Allow changing boundary string in upload:multipartFormData callback
Implementation Details 🚧
Changes MultipartFormData::boundary definition from constant
let
tovar
Testing Details 🔍
No test added