Replace all internal references to AFResult<T> with Result<T, Error> #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2019
jshier
requested changes
Aug 7, 2019
| @@ -25,83 +25,3 @@ | |||
| /// `Result` that always has an `Error` `Failure` type. | |||
| public typealias AFResult<T> = Result<T, Error> | |||
There was a problem hiding this comment.
There's really no reason to have just this typealias in its own file. It can be combined with the Result extensions.
There was a problem hiding this comment.
I've moved the typealias to Result+Alamofire.swift
Source/ResponseSerialization.swift
Outdated
| @@ -189,7 +189,7 @@ extension DataRequest { | |||
| appendResponseSerializer { | |||
| // Start work that should be on the serialization queue. | |||
| let start = CFAbsoluteTimeGetCurrent() | |||
| let result = AFResult { try responseSerializer.serialize(request: self.request, | |||
| let result = Result<Serializer.SerializedObject, Error> { try responseSerializer.serialize(request: self.request, | |||
There was a problem hiding this comment.
Please adjust the parameter alignment, and perhaps put the try on its own line to it isn't as wide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Remove all internal references to
AFResultbut keep theAFResulttypealias for migration purposes.This is an attempt to break apart #2864