Fix memory leak in NetworkReachabilityManager. #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Your're right, this is likely a bug. Would it be possible to demonstrate the cycle with a test? Say, create an optional manager, capture it weakly, start and stop it, then nil the reference and check the weak reference to see if it's still around? |
|
@jshier Done. Thanks for review :) |
|
@dirtmelon Looks like the added tests has an up to 10% failure rate, so there may be something else keeping the reference alive or internal async processes we need to wait for. I'm investigating, but I'd appreciate your attention too. |
|
That should fix it. |
|
Looks good, thanks! |
pull bot
pushed a commit
to scope-demo/Alamofire
that referenced
this pull request
May 15, 2020
* Fix memory leak. * Update deinitialization test for NetworkReachabilityManager. rename * Add assertion, clean up formatting. * Make deinit tests more resilient. Co-authored-by: Jon Shier <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
NetworkReachabilityManagerImplementation Details 🚧
As passRetained(_:) described, it creates an unmanaged reference with an unbalanced retain.The instance passed as value will leak if nothing eventually balances the retain.
In this case, we don't need to perform a retain, if the
NetworkReachabilityManagerdeinit, we will callstopListeningto set the context of callback nil.