[Refactoring] Replace many of force unwrapping usages with optional binding and where clause #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if downloadTaskDidFinishDownloadingToURL != nil { | ||
| let destination = downloadTaskDidFinishDownloadingToURL!(session, downloadTask, location) | ||
| if let handler = downloadTaskDidFinishDownloadingToURL { | ||
| let destination = handler(session, downloadTask, location) |
There was a problem hiding this comment.
In all the places where you are replacing force unwrapping with optional binding, could you use the following format instead?
if let downloadTaskDidFinishDownloadingToURL = self. downloadTaskDidFinishDownloadingToURL {
let destination = downloadTaskDidFinishDownloadingToURL(session, downloadTask, location)
}We have a open task for replacing all property accesses with the self. prefix for clarity. This would be a good place to start that work on all these changes.
|
Thanks for this PR @ikesyo! I have just a single comment that will require a few changes throughout the PR. If you could get those changes made, I'll gladly merge it. Thank you for taking the time to clean up the logic. |
…inding and where clause
|
@cnoon Thank you for the review! I've fixed the format what you pointed and rebased to master. Could you check it? |
cnoon
added a commit
that referenced
this pull request
Jul 10, 2015
[PR #557] Refactoring force unwrapping usage with optional binding and where clauses.
|
Great work @ikesyo...thanks for the changes! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.