This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Use virtual terminal processing on Windows #473
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes:
in favor of the 3rd-party
go-colorablemodule that implements all those conversions plus more. Furthermore,go-colorablewill attempt to enable "virtual terminal processing" under Windows which is a mode where ANSI escape codes are recognized natively by the system, and no conversions whatsoever will be necessary.Note: doesn't work yet. Not sure why, but any prompt is now hanging. I suspect the Windows-specific runereader is not liking the changes to Cursor.