Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker improvements #44

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

julichan
Copy link

@julichan julichan commented Jun 27, 2023

Thanks for the quick docker security fix previously. I'm planning to add several features later such as

  • multiple dashboards
  • multiple users

I think we should discuss this so we can help each others but that's not the conscern of this PR.

Here are few docker improvements you might want which i needed for proper security/usage on my side:

  1. use a folder for the database, this allow the usage of named volumes wheares file mounting is feature limited.
  2. removal of the expose component in dockerfile. For a reason, see Expose vs publish => expose is for development purposes and should not end in a production image. Publish adds a security layer whereas Expose does not not. Moreover Expose component result in the display of non opened port in docker ps command and the internal container port is configurable where Expose component is not configurable nor removable from another dockerfile.

@AlexSciFier AlexSciFier merged commit 0a9cf83 into AlexSciFier:master Jun 28, 2023
@julichan julichan deleted the docker-improvements branch July 7, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants