Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyper v2 compatibility #1

Closed
chabou opened this issue Apr 5, 2018 · 6 comments
Closed

Hyper v2 compatibility #1

chabou opened this issue Apr 5, 2018 · 6 comments

Comments

@chabou
Copy link

chabou commented Apr 5, 2018

Great job

Please take a look at my PR to make hyperpower compatible with our upcoming v2: vercel/hyperpower#52
@AlexanderPinkerton
Copy link
Owner

Thanks! Will do.

@AlexanderPinkerton
Copy link
Owner

I replicated your changes in this branch and it works in V2.

However, I have noticed that even after building a dist, the rendering in V2 seems to be far less smooth and the rendering stutters. Any ideas as to why?

@chabou
Copy link
Author

chabou commented Apr 10, 2018

I think this is due to electron 1.8 (Chrome v59): electron/electron#11051

@chabou
Copy link
Author

chabou commented Apr 25, 2018

Can you try our last Canary (2.1.0-canary.1) and give me your feedback?

@AlexanderPinkerton
Copy link
Owner

I will do this very soon

@AlexanderPinkerton
Copy link
Owner

Seems to be much better now. I assume this has something to do with the gpu blacklist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chabou @AlexanderPinkerton