Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with hyper v2 #52

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Compatibility with hyper v2 #52

merged 2 commits into from
Apr 16, 2018

Conversation

chabou
Copy link
Collaborator

@chabou chabou commented Jan 22, 2018

It uses onCursorMove API introduced by vercel/hyper#2629

Bonus: performance issue has been fixed https://github.com/zeit/hyper-power/pull/52/files#r163001309

@@ -147,7 +149,7 @@ exports.decorateTerm = (Term, { React, notify }) => {

// Draw the next frame in the particle simulation.
_drawFrame () {
this._canvasContext.clearRect(0, 0, this._canvas.width, this._canvas.height);
this._particles.length && this._canvasContext.clearRect(0, 0, this._canvas.width, this._canvas.height);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear only if there is some particule on last call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants