Add the option to pass ICE servers with an async WebRTC offer #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhaus
force-pushed
the
iceServersWithOffer
branch
from
fa7d8d2
to
1f36044
Compare
|
Closing in favor of 16e4831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to pass ICE servers with an async WebRTC offer, which are merged with the servers defined in the config. I have added the option only for the async WebRTC offer V2, but it can also be added for the sync V2 one if needed.
This is helpful if you are using a TURN server, where the credentials are only valid for a certain time.
Without this PR, the servers can only be set via the config file. Changes in the config file take effect only after restarting the go2rtc binary, which closes running streams.