Fix hanging webrtc streams #1428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexxIT
added a commit
that referenced
this pull request
Nov 2, 2024
|
Thanks for pointing to exact place of problem. But I have fixed this with another way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v1.9.4 it is no longer possible to stop webrtc streams (
webrtc:ws://). Go2RTC attempts to stop them and logs it, but on the client side the Peer Connection never disconnects, making it impossible to stop the stream.This Pull Request reimplements the stop function for the webrtc producer, which terminates the Peer Connection.