Feature: Make kill signal configurable

[dadav]

This makes it possible to end exec commands gracefully.

Also fixed a typo on the way :)

Fixes #870

[dadav]

This also makes it possible to use gphoto2 as a source.

Like this:

exec:
  signal: sigint

streams:
  canon: exec:gphoto2 --capture-movie --stdout

[AlexxIT]

I don't think this is good idea to use same kill signal for all exec sources. It should be #param like ffmpeg and other sources.

[dadav]

I don't think this is good idea to use same kill signal for all exec sources. It should be #param like ffmpeg and other sources.

Good point, I'm gonna fix it

[skrashevich]

The process may not terminating upon receipt of sigint. It's important to implement some timeout, after which sigkill will be sent. Otherwise, zombie processes may appear

[dadav]

Better? @AlexxIT

[skrashevich]

What happens if anyone set #killtimeout to zero or negative number? ;)

UPD: oops, looks like, that nothing bad

[dadav]

What happens if anyone set #killtimeout to zero or negative number? ;)

UPD: oops, looks like, that nothing bad

UPD: Negative or zero number will result in an immediate SIGKILL.

[dadav]

Is there anything I can work on to make this PR more acceptable?

[AlexxIT]

Sorry. Don't have time to review. Fixing my other projects after Home Assistant 2024.1 update...

[dadav]

Just realized this could make problems on windows/darwin. Need to invest some time in os specific code..

[dadav]

This should work..

[AlexxIT]

Thanks! I've rewritten the code to make it simpler.

[felipecrs]

I would probably change the default behavior, instead of killing by default, sending SIGTERM and waiting some arbitrary time like 5 seconds before killing the process.

[AlexxIT]

For example, ffmpeg will fail in any way, because stdout will be closed before kill signal.

[AlexxIT]

https://github.com/AlexxIT/go2rtc/releases/tag/v1.9.0