Issues/import errors #98
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might be able to add a DB migration mapping the faulty currency name (currency code) to only currency code. That way user won't have to select the currency again.
I think that sounds like a good idea. Do you have permissions to set it up or do you want me to do it? |
|
I believe I have permission to create the branch. I'll just have to figure out how to limit a step to only run when pushes happen on specific branches. This way pushes to dev create a rc image and not mark it lastest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #42 fuelly imports
Currency was saved as currency name (currency code) when the backend code was expecting only currency code.
Added a notification for existing users with the currency currently set improperly.
I would like a dev branch to push to and an added task within the github workflow to push a new rc image to docker hub without setting the new release to the latest.