Mark as deleted #32
Merged
Mark as deleted #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 88.56% 89.20% +0.64%
==========================================
Files 12 11 -1
Lines 883 954 +71
==========================================
+ Hits 782 851 +69
- Misses 101 103 +2
☔ View full report in Codecov by Sentry. |
olynch
requested changes
Jul 11, 2023
rendering parts rename rebase cleanup more export
These macros are in Catlab, not ACSets.
Also, expand and clean up docstring for these types.
epatters
reviewed
Jul 17, 2023
This had effectively disabled all the other tests!
Besides being uncovered by the tests, it's not very natural since the keys of the column are generally unordered.
The abstract base type is now called simply `PartsType`.
epatters
reviewed
Jul 18, 2023
There was a problem hiding this comment.
@kris-brown, apart from this last question, I'm happy with this PR!
epatters
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to representing the set of parts with an int (i.e.
1:n), this PR is a move towards generalizing that data structure. We start with just supporting eitherIntorBitSetas a parameterpart_typewhen making an ACSet type.Deletion is trivial for BitSet-backed ACSets but the work is done in
gc!for garbage collection.Currently there is nothing at the type level to distinguish ACSets with one part type vs another. It is assumed (though not presently enforced) that all parts must be the same type.