Cm/docs pmap #218
Cm/docs pmap #218
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 75.13% 77.75% +2.62%
==========================================
Files 5 5
Lines 559 562 +3
==========================================
+ Hits 420 437 +17
+ Misses 139 125 -14 ☔ View full report in Codecov by Sentry. |
docs/Manifest.toml
Outdated
| @@ -0,0 +1,2734 @@ | |||
| # This file is machine-generated - editing it directly is not advised | |||
There was a problem hiding this comment.
We shouldn't check in the docs manifest.
docs/assets/sharp_op.jl
Outdated
There was a problem hiding this comment.
@lukem12345 do we still need this file, or did it get upstreamed?
There was a problem hiding this comment.
This is upstreamed. The file that includes this sharp implementation should have its include of this removed, and the generate function can also get pruned.
| push!(pages, "Overview" => "overview.md") | ||
| push!(pages, "Equations" => "equations.md") | ||
| push!(pages, "BC Debug" => "bc_debug.md") | ||
| push!(pages, "ASCII Operators" => "ascii.md") |
There was a problem hiding this comment.
since this part is being hard coded, it could still be a Vector{Pair{String,String}} literal and then you can push to it for the dynamically generated part later.
docs/make.jl
Outdated
| # end | ||
| # # push!(examples, exampledirs[d] => dir_dict) | ||
| #end | ||
| #push!(pages, "Examples" => examples) |
docs/make.jl
Outdated
| # ], | ||
| # "Canonical Models" => "canon.md", | ||
| # "Library Reference" => "api.md" | ||
| # ] |
docs/src/ice_dynamics.md
Outdated
| @@ -1,528 +0,0 @@ | |||
| # Halfar's model of glacial flow | |||
There was a problem hiding this comment.
why did we delete this page?
There was a problem hiding this comment.
It looks like docs\src\grigoriev.md was errantly git mv’d to docs\src\climate\ice_dynamics.md, and the real docs\src\ice_dynamics.md was deleted.
|
It looks like the history for grigoriev.md is incorrect now |
|
Comment out the brusselator example and see if works @quffaro |
This branch was created when main had docs which were formatted agreeably with Literate. Therefore the other branches related to this task, pending inspection, should be disregarded. This
make.jlfile partially automates adding examples to our docs. In a future branch: